Vendor bump and fixups#1
Closed
Miciah wants to merge 3 commits intogcs278:NE-942from
Closed
Conversation
The cluster ingress config object can now specify the AWS ELB type that was specified when installing the cluster. The ingress operator will refer to this object whenever someone deletes the default ingresscontroller and the operator has to recreate it. Before this commit, the operator would always set the default ELB type (Classic ELB) when creating the default ingresscontroller. Fixes https://issues.redhat.com/browse/NE-975 - `pkg/operator/operator.go`: Check if infrastructure object was set with the LB type "NLB" and create the ingresscontroller accordingly. - `pkg/operator/ingress/controller.go`: setDefaultPublishingStrategy refactoring. Introduce a new setDefaultPublishingStrategy function to simplify setDefaultPublishingStrategy, correct the defaulting behavior when status.endpointPublishingStrategy is nil. - `pkg/operator/controller/ingress/controller_test.go`: Add some test cases to TestSetDefaultPublishingStrategySetsPlatformDefaults, and revert some changes to TestSetDefaultPublishingStrategyHandlesUpdates. Modified-by: Grant Spence <gspence@redhat.com>
Bump to github.com/openshift/api@24ee13c10f3bf7c3320392ba687a5a42bb3c04c4 to get ingresses.config.openshift.io with the correctly capitalized spec.loadBalancer field name. * go.mod: Update. * go.sum: * vendor/github.com/openshift/api/*: * vendor/modules.txt: Regenerate.
gcs278
reviewed
Oct 13, 2022
| github.com/google/go-cmp v0.5.8 | ||
| github.com/kevinburke/go-bindata v3.11.0+incompatible | ||
| github.com/openshift/api v0.0.0-20220907152121-48d78630feb3 | ||
| github.com/openshift/api v0.0.0-20220927015011-24ee13c10f3b |
Owner
There was a problem hiding this comment.
Miheer original vendor the merge commit github.com/openshift/api v0.0.0-20220929023536-18c298295790 but look like you took the individual commit. Does that matter?
Owner
|
Miheer took care of the merge so closing this. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.